refactor(provider): stop custom loaders using facades

[kitlangton]

Summary

• stop provider custom loaders from calling static Auth.get(...) and Config.get() facades
• capture yielded auth and config services inside the provider layer and expose only tiny local Promise bridges where the loader contract still requires promises
• add focused opencode provider regression tests for config-key and auth-backed paid model loading

Testing

• bun run test test/provider/provider.test.ts test/provider/amazon-bedrock.test.ts
• bun typecheck

[luanweslley77]

Hi @kitlangton, noticed this PR is still in draft — wanted to flag a related timing issue we've been investigating that might be worth considering as part of this refactor.
We traced a bug (#20026) where plugin providers registered via the config() hook disappear after /instance/dispose. The root cause is that configProviders = Object.entries(cfg.provider ?? {}) is captured as a stale snapshot before plugin.list() runs and calls the config() hook. When plugins modify cfg.provider to add their providers, it's already too late.
Your refactor injects dep (with auth and config bridges) into custom loaders, which is a nice improvement — but it doesn't address the ordering of plugin.list() relative to configProviders.
Since this PR is still in draft, would you be open to proposing a solution that also addresses the initialization ordering? We have a fix in PR #20777 that moves plugin.list() to run before configProviders, but we'd be happy to see a more elegant approach from you if you think it fits better into this refactor.
Happy to collaborate or adjust our approach if you have ideas.

[kitlangton]

Hi @kitlangton, noticed this PR is still in draft — wanted to flag a related timing issue we've been investigating that might be worth considering as part of this refactor. We traced a bug (#20026) where plugin providers registered via the config() hook disappear after /instance/dispose. The root cause is that configProviders = Object.entries(cfg.provider ?? {}) is captured as a stale snapshot before plugin.list() runs and calls the config() hook. When plugins modify cfg.provider to add their providers, it's already too late. Your refactor injects dep (with auth and config bridges) into custom loaders, which is a nice improvement — but it doesn't address the ordering of plugin.list() relative to configProviders. Since this PR is still in draft, would you be open to proposing a solution that also addresses the initialization ordering? We have a fix in PR #20777 that moves plugin.list() to run before configProviders, but we'd be happy to see a more elegant approach from you if you think it fits better into this refactor. Happy to collaborate or adjust our approach if you have ideas.

Hey, thanks. I added a regression test which did indeed reproduce the issue! I've included your changes into this PR. 🫡

[Copilot]

Pull request overview

Refactors provider-layer custom loaders to stop calling static Auth.get(...) / Config.get() facades by injecting auth and config services into the loader layer, and adds regression tests around opencode paid model loading behavior.

Changes:

• Converted provider custom loaders to return Effect and added an injected dependency bridge for auth/config.
• Updated loader execution to run these effects directly (instead of wrapping promise-returning loaders).
• Added opencode regression tests ensuring paid models remain available when an apiKey is present in config or auth storage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
packages/opencode/src/provider/provider.ts	Refactors custom provider loaders to use injected auth/config services via Effect instead of static facades.
packages/opencode/test/provider/provider.test.ts	Adds regression tests for opencode paid model filtering based on config apiKey or auth presence.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.