refactor(effect): move read tool onto defineEffect#20793
Merged
kitlangton merged 5 commits intorefactor/effectify-task-toolfrom Apr 4, 2026
Merged
refactor(effect): move read tool onto defineEffect#20793kitlangton merged 5 commits intorefactor/effectify-task-toolfrom
kitlangton merged 5 commits intorefactor/effectify-task-toolfrom
Conversation
This was referenced Apr 3, 2026
kitlangton
force-pushed
the
refactor/effectify-task-tool
branch
from
3f88048 to
117a6a3
Compare
kitlangton
force-pushed
the
refactor/effectify-read-tool
branch
from
1f53c0f to
eed65bf
Compare
kitlangton
force-pushed
the
refactor/effectify-task-tool
branch
from
117a6a3 to
74a2abe
Compare
kitlangton
force-pushed
the
refactor/effectify-read-tool
branch
from
eed65bf to
63168d3
Compare
Yield AppFileSystem, Instruction, LSP, and FileTime from the read tool effect so the tool closes over real services instead of static facades. Rewrite read tool tests to use the effect test harness and document the migration pattern for effectified tools.
Move the read tool body onto a named Effect path and keep a single Promise bridge at execute(). This keeps the service graph wiring from the previous commit while reducing runPromise islands inside the tool implementation.
Keep LSP warmup off the read critical path and use AppFileSystem helpers directly in the read tool. Update the migration note to describe the single-bridge pattern that the tool now follows.
Reduce helper indirection in the read tool tests by adding a scope-local run helper, reusing a shared permission capture helper, and keeping env-permission assertions inside a single instance scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadToolontoTool.defineEffect(...)so it follows the new tool-constructor shaperead.test.tswith a tiny local helper so the existing read test body can keep callingReadTool.init()-style semanticsValidation
bun typecheckbun run test test/tool/read.test.ts test/tool/task.test.ts test/tool/question.test.tsbun run test test/session/prompt-effect.test.ts --test-name-pattern "cancel finalizes subtask tool state"Stack
Base:
devMerged
refactor/effectify-task-toolCurrent / Remaining
2. #20793
refactor/effectify-read-tool- current