fix(opencode): Move pty connection to custom auth check on server for node-ws#21490
Closed
OpeOginni wants to merge 2 commits intoanomalyco:devfrom
Closed
fix(opencode): Move pty connection to custom auth check on server for node-ws#21490OpeOginni wants to merge 2 commits intoanomalyco:devfrom
OpeOginni wants to merge 2 commits intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21480
Closes #21469
Closes #21440
Closes #21541
Type of change
What does this PR do?
/pty/:id/connectinstead of relying on browser/webview Basic auth during upgradeThis is not the cleanest fix, but to make a small PR that does fix the issue its the best, without reverting to using the
hono/bundep.How did you verify your code works?
Tested my dev desktop build and the terminal works as it should
Screenshots / recordings
Checklist