refactor(tool): convert apply_patch to Tool.defineEffect#21938
Merged
kitlangton merged 2 commits intodevfrom Apr 10, 2026
Merged
refactor(tool): convert apply_patch to Tool.defineEffect#21938kitlangton merged 2 commits intodevfrom
kitlangton merged 2 commits intodevfrom
Conversation
kitlangton
force-pushed
the
kit/tool-effect-apply-patch
branch
2 times, most recently
from
3cd643f to
5985901
Compare
…fect Migrate apply_patch tool to the Effect pattern: yield LSP.Service for touchFile/diagnostics, wrap fs calls and ctx.ask in Effect.promise, use assertExternalDirectoryEffect, and return execute via Effect.runPromise with Effect.orDie. Update registry to yield ApplyPatchTool and pass the resolved value to Tool.init. Update tests to use ManagedRuntime with LSP.defaultLayer.
kitlangton
force-pushed
the
kit/tool-effect-apply-patch
branch
from
5985901 to
226d16d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_patchtool fromTool.definetoTool.defineEffectpatternLSP.ServicefortouchFile/diagnosticscalls instead of using static methodsfs/promisescalls,ctx.ask, andFormat.fileinEffect.promiseassertExternalDirectoryEffectinstead ofassertExternalDirectoryexecuteviaEffect.runPromisewithEffect.orDieApplyPatchTooland pass resolved value toTool.initManagedRuntimewithLSP.defaultLayerTest plan
bun run typecheckpasses (no new errors)bun run test test/tool/apply_patch.test.ts— all 26 tests pass