feat: add AppRuntime for unified service composition#21953
Merged
kitlangton merged 1 commit intodevfrom Apr 10, 2026
Merged
Conversation
Composes every service defaultLayer into one flat list and creates a shared ManagedRuntime. This is the foundation for migrating facade callers to use AppRuntime directly instead of per-service makeRuntime. Also exports previously-private defaultLayers from SessionPrompt, Vcs, Worktree, Pty, and McpAuth, and adds Bus.defaultLayer alias for consistency.
mrsimpson
pushed a commit
to mrsimpson/opencode
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/effect/app-runtime.ts— a singleManagedRuntimethat composes every service'sdefaultLayerinto one flat listmemoMapso layer construction is fully deduplicateddefaultLayerfrom SessionPrompt, Vcs, Worktree, Pty, McpAuthBus.defaultLayeralias for pattern consistencyWhy
Each service currently has its own
makeRuntime+defaultLayer, creating ~40 independentManagedRuntimeinstances. Facade methods hop through these per-service runtimes, which was necessary when the layer graph had cycles. Now that cycles are resolved, we can compose everything into one runtime.This is the foundation for gradually:
AppRuntimedirectlymakeRuntimecalls as their facades become unusedEffect.promise(() => Facade.method(...))hops with directyield* ServicecallsTest plan