refactor: destroy Todo facade#21962
Merged
kitlangton merged 3 commits intodevfrom Apr 11, 2026
Merged
Conversation
Second facade destruction, proving the non-effectful-caller → AppRuntime pattern. The single caller (server route) now uses AppRuntime.runPromise(Todo.Service.use(...)) instead of the Todo.get facade. The async facade and makeRuntime are removed from session/todo.ts.
kitlangton
force-pushed
the
kit/migrate-todo-facade
branch
from
f838f0f to
1a68fe7
Compare
mrsimpson
pushed a commit
to mrsimpson/opencode
that referenced
this pull request
Apr 14, 2026
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second facade destruction. Tiny diff — proves the second migration pattern (non-effectful caller → AppRuntime).
Changes
server/routes/session.ts— the GET/session/:id/todohandler now doesAppRuntime.runPromise(Todo.Service.use((svc) => svc.get(sessionID)))instead of calling theTodo.getpromise facadesession/todo.ts— deleted theexport async function getfacade, themakeRuntime(...)line, and the unusedmakeRuntimeimportTest plan