refactor: extract LSP diagnostic report formatter#21964
Merged
kitlangton merged 1 commit intodevfrom Apr 11, 2026
Merged
Conversation
Adds LSP.Diagnostic.report(file, issues) to centralize the filter/cap/ format logic that was duplicated across write, edit, and apply_patch. Call sites keep control over the surrounding header text.
mrsimpson
pushed a commit
to mrsimpson/opencode
that referenced
this pull request
Apr 14, 2026
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
LSP.Diagnostic.report(file, issues)next to the existingLSP.Diagnostic.prettyto centralize the filter / cap /<diagnostics>-block formatting that was duplicated acrosswrite,edit, andapply_patch.Call sites keep control over their surrounding header text ("in this file", "in other files", "in {rel}") since that's the only real variation.
Net −11 lines, no new files.
Test plan
bun run typecheckinpackages/opencode