refactor(session): eliminate Effect.promise roundtrips for sync MessageV2.stream#21973
Merged
kitlangton merged 1 commit intodevfrom Apr 11, 2026
Merged
refactor(session): eliminate Effect.promise roundtrips for sync MessageV2.stream#21973kitlangton merged 1 commit intodevfrom
kitlangton merged 1 commit intodevfrom
Conversation
kitlangton
force-pushed
the
kit/eliminate-message-v2-roundtrips
branch
2 times, most recently
from
ca9e775 to
9b77f8e
Compare
…essageV2.stream calls MessageV2.stream is a synchronous generator, so wrapping it in Effect.promise with `for await` is an unnecessary async roundtrip. Use Effect.sync with a plain `for` loop instead.
kitlangton
force-pushed
the
kit/eliminate-message-v2-roundtrips
branch
from
9b77f8e to
a28fc76
Compare
mrsimpson
pushed a commit
to mrsimpson/opencode
that referenced
this pull request
Apr 14, 2026
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Effect.promise(async () => { for await ... MessageV2.stream() })withEffect.sync(() => { for ... MessageV2.stream() })in two places inprompt.tsMessageV2.streamis a synchronous generator, so wrapping it inEffect.promisewithfor awaitcreates an unnecessary async roundtripChanged callers
lastModel— finds the most recent user message's model configlastAssistant— finds the most recent assistant messageWhat was NOT changed
MessageV2facade calls are either already using Effect versions (toModelMessagesEffect,filterCompactedEffect), already wrapped inEffect.sync, or called from non-Effect context (CLI, server routes, tests)Test plan
bun run typecheckpasses (no new errors)@opentui/solid/preloadissue)