refactor(tool): use Session.Service directly in TaskTool#21975
Merged
kitlangton merged 1 commit intodevfrom Apr 11, 2026
Merged
refactor(tool): use Session.Service directly in TaskTool#21975kitlangton merged 1 commit intodevfrom
kitlangton merged 1 commit intodevfrom
Conversation
kitlangton
force-pushed
the
worktree-agent-a7964dca
branch
from
77ab07c to
1979a7a
Compare
mrsimpson
pushed a commit
to mrsimpson/opencode
that referenced
this pull request
Apr 14, 2026
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yield* Session.Serviceinstead of callingSession.get/Session.createfacades throughEffect.promise, eliminating unnecessary runtime roundtripssessions.getcall usesEffect.catchCauseto handleNotFoundError(a thrown exception) gracefully, matching the original.catch(() => undefined)behaviorTest plan
bun test test/tool/task.test.ts— all 6 tests passbun test test/session/— all 242 tests passbun run typecheck— no new errors in src/