Skip to content

fix(tui): surface nested subagent prompts#21996

Open
feddericovonwernich wants to merge 1 commit intoanomalyco:devfrom
feddericovonwernich:fix/tui-nested-request-surfacing
Open

fix(tui): surface nested subagent prompts#21996
feddericovonwernich wants to merge 1 commit intoanomalyco:devfrom
feddericovonwernich:fix/tui-nested-request-surfacing

Conversation

@feddericovonwernich
Copy link
Copy Markdown

@feddericovonwernich feddericovonwernich commented Apr 11, 2026

Issue for this PR

Closes #13715

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The root TUI session only surfaced permission/question requests from direct child sessions, so prompts from deeper nested subagent sessions could hang without being shown.

This PR adds descendant-aware request selection (root-first traversal) and wires it into the TUI session route. It also adds regression tests at selector level and sync-provider integration level to cover nested prompt surfacing.

How did you verify your code works?

  • Reproduced with red/green flow:
    • temporarily reverted traversal logic and confirmed nested-grandchild tests fail
    • restored fix and confirmed tests pass
  • Ran locally:
    • bun test test/cli/tui/session-request-tree.test.ts
    • bun test test/cli/tui/sync-provider.test.tsx
  • Compiled and tested locally with the built binary; nested prompt surfacing works in live usage.

Screenshots / recordings

N/A (logic + tests change; no UI layout/styling change)

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions bot added the needs:compliance This means the issue will auto-close after 2 hours. label Apr 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found one potentially related PR:

Related PR:

The current PR #21996 is explicitly mentioned as being related to #13719 and appears to be a follow-up or enhancement with broader test coverage for nested subagent prompt handling. They're addressing related but distinct aspects of the same feature area.

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@feddericovonwernich feddericovonwernich force-pushed the fix/tui-nested-request-surfacing branch from 8c196ca to e26468d Compare April 11, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permission asks from nested subagent sessions silently hang

1 participant