fix(plugin): import solid runtime plugin support in plugin loader#22046
Open
YumaKakuya wants to merge 1 commit intoanomalyco:devfrom
Open
fix(plugin): import solid runtime plugin support in plugin loader#22046YumaKakuya wants to merge 1 commit intoanomalyco:devfrom
YumaKakuya wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22045
Type of change
What does this PR do?
The TUI plugin runtime imports
@opentui/solid/runtime-plugin-supportat the top ofpackages/opencode/src/cli/cmd/tui/plugin/runtime.ts:1, which lets Solid plugins register themselves inside a compiled binary. The plugin loader used by the server process atpackages/opencode/src/plugin/loader.tsdoes not have the same import, so a server plugin that ships compiled.tsxcomponents cannot find its Solid runtime when loaded from a compiled binary.The fix is a single import at the top of
plugin/loader.ts, matching the existing TUI pattern.How did you verify your code works?
I hit this while working on a local server plugin that ships a compiled
.tsxcomponent: without the import the plugin silently failed to mount, with the import it renders correctly. I did not add a unit test — the change is a single import that mirrors the TUI pattern, and there's no existing test coverage for plugin loader imports to extend.Screenshots / recordings
N/A — no UI change.
Checklist