Skip to content

refactor(question): destroy Question facade#22092

Merged
kitlangton merged 1 commit intodevfrom
worktree-agent-ac5c315d
Apr 12, 2026
Merged

refactor(question): destroy Question facade#22092
kitlangton merged 1 commit intodevfrom
worktree-agent-ac5c315d

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • Removed makeRuntime and facade functions (ask, reply, reject, list) from Question
  • Converted server/routes/question.ts to AppRuntime.runPromise(Question.Service.use(...))
  • Converted 14 tests to effectful style

Verification

  • bun run typecheck — clean
  • bun run test test/question/question.test.ts — 14/14

@kitlangton kitlangton force-pushed the worktree-agent-ac5c315d branch from 7202c06 to f8b874f Compare April 12, 2026 00:42
@kitlangton kitlangton marked this pull request as ready for review April 12, 2026 00:56
@kitlangton kitlangton merged commit 003010b into dev Apr 12, 2026
8 of 10 checks passed
@kitlangton kitlangton deleted the worktree-agent-ac5c315d branch April 12, 2026 00:57
mrsimpson pushed a commit to mrsimpson/opencode that referenced this pull request Apr 14, 2026
xywsxp pushed a commit to xywsxp/opencode that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant