Skip to content

chore: refactor log.ts, go back to glob but add sort #22107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rekram1-node merged 1 commit into from
Apr 12, 2026
Merged

chore: refactor log.ts, go back to glob but add sort #22107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/opencode/src/util/log.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import fs from "fs/promises"
import { createWriteStream } from "fs"
import { Global } from "../global"
import z from "zod"
import { Glob } from "./glob"

export namespace Log {
export const Level = z.enum(["DEBUG", "INFO", "WARN", "ERROR"]).meta({ ref: "LogLevel", description: "Log level" })
Expand All @@ -15,7 +16,6 @@ export namespace Log {
ERROR: 3,
}
const keep = 10
const rx = /^\d{4}-\d{2}-\d{2}T\d{6}\.log$/

let level: Level = "INFO"

Expand Down Expand Up @@ -79,7 +79,15 @@ export namespace Log {
}

async function cleanup(dir: string) {
const files = (await fs.readdir(dir).catch(() => [])).filter((file) => rx.test(file)).sort()
const files = (
await Glob.scan("????-??-??T??????.log", {
cwd: dir,
absolute: false,
include: "file",
}).catch(() => [])
)
.filter((file) => path.basename(file) === file)
.sort()
if (files.length <= keep) return

const doomed = files.slice(0, -keep)
Expand Down
Loading