Skip to content

refactor: remove vcs async facade exports#22304

Merged
kitlangton merged 1 commit intodevfrom
facade/vcs
Apr 13, 2026
Merged

refactor: remove vcs async facade exports#22304
kitlangton merged 1 commit intodevfrom
facade/vcs

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • switch instance VCS routes from the async facade exports to AppRuntime.runPromise(Effect.gen(...))
  • convert the VCS tests to resolve Vcs.Service from context instead of calling facade helpers directly
  • remove the makeRuntime-backed async exports from src/project/vcs.ts

Validation

  • bun run test test/project/vcs.test.ts (fails before running tests: missing @opentui/solid/preload in this checkout)
  • bun typecheck (fails in this checkout due existing dependency/type-resolution errors unrelated to VCS)

@kitlangton kitlangton marked this pull request as ready for review April 13, 2026 15:22
@kitlangton kitlangton merged commit ca62001 into dev Apr 13, 2026
11 of 13 checks passed
@kitlangton kitlangton deleted the facade/vcs branch April 13, 2026 15:22
mrsimpson pushed a commit to mrsimpson/opencode that referenced this pull request Apr 14, 2026
xywsxp pushed a commit to xywsxp/opencode that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant