refactor(skill): remove async facade exports#22308
Merged
kitlangton merged 2 commits intodevfrom Apr 13, 2026
Merged
Conversation
mrsimpson
pushed a commit
to mrsimpson/opencode
that referenced
this pull request
Apr 14, 2026
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppRuntime.runPromise(Effect.gen(...))and readSkill.Servicefrom contexttest/skill/skill.test.tsto effect-style tests that yieldSkill.Servicemethods instead of calling skill facade helpersmakeRuntime-backed async exports fromsrc/skill/index.tswhile keepingSkill.fmt(...)Validation
bun run test test/skill/skill.test.ts(fails in this temp workspace because Bun preload@opentui/solid/preloadis not installed here)bun typecheck(fails in this temp workspace due unrelated missing workspace dependencies / existing package-wide typecheck issues)