Skip to content

fix(effect): preserve logger context in prompt runs#22496

Merged
kitlangton merged 1 commit intodevfrom
fix-effect-logger-context
Apr 14, 2026
Merged

fix(effect): preserve logger context in prompt runs#22496
kitlangton merged 1 commit intodevfrom
fix-effect-logger-context

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • merge Observability.layer directly into AppRuntime so it installs the same logger set as makeRuntime(...)
  • switch the internal SessionPrompt promise/fork bridge to Effect.runPromiseWith(ctx) and Effect.runForkWith(ctx) so prompt runs keep the active logger context
  • add a regression test proving AppRuntime includes EffectLogger just like makeRuntime(...)

Testing

  • bun run test test/effect/app-runtime-logger.test.ts test/session/prompt-effect.test.ts
  • bun run typecheck

Notes

@kitlangton kitlangton merged commit aeb7d99 into dev Apr 14, 2026
10 of 11 checks passed
@kitlangton kitlangton deleted the fix-effect-logger-context branch April 14, 2026 21:33
cmaloney111 pushed a commit to psi-oss/gpd-app that referenced this pull request Apr 20, 2026
xywsxp pushed a commit to xywsxp/opencode that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant