Skip to content

fix(effect): preserve context across callback bridges#22497

Open
kitlangton wants to merge 2 commits intodevfrom
fix-effect-context-bridges
Open

fix(effect): preserve context across callback bridges#22497
kitlangton wants to merge 2 commits intodevfrom
fix-effect-context-bridges

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • capture the active Effect context before crossing callback boundaries in MCP, PTY, plugin, bus, command, and provider bridges
  • replace bare Effect.runPromise / Effect.runFork calls at those boundaries with runPromiseWith(ctx) / runForkWith(ctx)
  • stop re-providing EffectLogger.layer at those sites now that the runtime logger context is preserved explicitly

Testing

  • bun run typecheck
  • bun run test test/plugin/trigger.test.ts test/pty/pty-output-isolation.test.ts
  • bun run test test/mcp/lifecycle.test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant