feat(core): add fence to make all methods strongly consistent when syncing#22679
Merged
feat(core): add fence to make all methods strongly consistent when syncing#22679
Conversation
goniz
reviewed
Apr 16, 2026
| log.info("header", { | ||
| diff: current, | ||
| }) | ||
| c.res.headers.set(HEADER, JSON.stringify(current)) |
Contributor
There was a problem hiding this comment.
Can this end up being too large?
It depends on the runtime, but Bun has 16k limit on sum of all headers.
Can be changed thou: https://bun.com/docs/runtime#param-max-http-header-size
jerome-benoit
pushed a commit
to jerome-benoit/opencode
that referenced
this pull request
Apr 16, 2026
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a fence which is the sync state sent back on every response from the workspace server, which the control plane server can read and wait until it's all synced up. This makes all of our methods strongly consistent again