feat: enable type-aware no-base-to-string rule, fix 56 violations#22750
Merged
kitlangton merged 1 commit intodevfrom Apr 16, 2026
Merged
feat: enable type-aware no-base-to-string rule, fix 56 violations#22750kitlangton merged 1 commit intodevfrom
kitlangton merged 1 commit intodevfrom
Conversation
Add oxlint-tsgolint and enable no-base-to-string to catch objects being coerced to strings without a meaningful toString(). Fix 56 violations: convert form.get()?.toString() to typed casts, add explicit String() coercions, use error.message instead of string interpolation, and suppress intentional unknown-to-string coercions.
kitlangton
force-pushed
the
kit/oxlint-base-to-string
branch
from
a12a1a2 to
fe38816
Compare
jerome-benoit
pushed a commit
to jerome-benoit/opencode
that referenced
this pull request
Apr 16, 2026
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oxlint-tsgolintand enableno-base-to-stringruletoString()Fix patterns
form.get("x")?.toString()in console routesform.get("x") as string | null(text inputs always return strings)${error}on unknown typeserror instanceof Error ? error.message : String(error)String(unknown)on log/error valuesrequest.toString()on Requesttypeof request === "string" ? request : request.urlpart.image.toString()on DataContentString(part.image)String()or type narrowing