Skip to content

fix: restore .gitignore logic for config dirs and migrate to shared Npm service#22772

Merged
thdxr merged 1 commit intodevfrom
config-restore-gitignore
Apr 16, 2026
Merged

fix: restore .gitignore logic for config dirs and migrate to shared Npm service#22772
thdxr merged 1 commit intodevfrom
config-restore-gitignore

Conversation

@thdxr
Copy link
Copy Markdown
Member

@thdxr thdxr commented Apr 16, 2026

Summary

  • Restore the .gitignore creation logic for .opencode config directories that was lost during the migration to the shared Npm.Service
  • The gitignore ensures node_modules, package.json, package-lock.json, bun.lock stay out of version control in config dirs
  • Extracted a setupConfigDir helper that writes the .gitignore and runs npmSvc.install, forked in the background
  • Untracked the accidentally committed .opencode/package-lock.json
  • Fixed config tests to use Layer.mock(Npm.Service) instead of spyOn(Npm, "install") since Npm is now an Effect service
  • Removed installDeps deduplication/serialization tests that now belong in the shared Npm package
  • Added missing Npm.defaultLayer to test layers

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@thdxr thdxr merged commit ef90b93 into dev Apr 16, 2026
9 of 11 checks passed
@thdxr thdxr deleted the config-restore-gitignore branch April 16, 2026 07:14
jerome-benoit pushed a commit to jerome-benoit/opencode that referenced this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant