refactor: unwrap ConfigPlugin namespace to flat exports + self-reexport#22876
Merged
kitlangton merged 1 commit intodevfrom Apr 16, 2026
Merged
refactor: unwrap ConfigPlugin namespace to flat exports + self-reexport#22876kitlangton merged 1 commit intodevfrom
kitlangton merged 1 commit intodevfrom
Conversation
kitlangton
force-pushed
the
kit/self-reexport-config-plugin
branch
from
e24e992 to
bce4ee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigPluginnamespace insrc/config/plugin.tsto flat top-level exports.export * as ConfigPlugin from "./plugin") so existingimport { ConfigPlugin } from "@/config/plugin"consumers keep the sameConfigPlugin.Spec,ConfigPlugin.pluginSpecifier, etc. ergonomics.Why
export namespacecompiles to an IIFE that blocks bundler tree-shaking and is not supported by Node's native TypeScript stripping.ConfigPlugin.fooAPI stays, but the module is now tree-shakable.Verification
bunx --bun tsgo --noEmitfrompackages/opencode(only pre-existing unrelated@npmcli/arboristwarning).bun run --conditions=browser ./src/index.ts generate— passes (catches circular import regressions).bun run test test/config/config.test.ts— 73 pass.bun run test test/config/tui.test.ts— 23 pass, 3 pre-existing skips.