tui: boost favorites and recents when filtering model dialog#23161
Closed
kitlangton wants to merge 2 commits intodevfrom
Closed
tui: boost favorites and recents when filtering model dialog#23161kitlangton wants to merge 2 commits intodevfrom
kitlangton wants to merge 2 commits intodevfrom
Conversation
When the user types a query in the model selection dialog, favorites and recents previously lost all positional priority and were ranked purely by fuzzysort score on title/category. Now matching favorites float to the top, followed by matching recents, then everything else, each group preserving fuzzysort order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When typing in the model selection dialog, favorites and recents previously lost all positional priority — they were demoted into the flat provider pool and ranked purely by fuzzysort score on
title/category. A favorite would only rank high if its name happened to fuzzy-match well.This change partitions the fuzzysort matches so favorites float to the top, recents come next, then everything else. Each group preserves fuzzysort's relative order, and the threshold still applies (non-matching favorites are not force-shown).
Notes
dialog-model.tsx. No-query behavior is unchanged.