fix(auth): filter out invalid entries in auth list#23289
Open
bensantora wants to merge 4 commits intoanomalyco:devfrom
Open
fix(auth): filter out invalid entries in auth list#23289bensantora wants to merge 4 commits intoanomalyco:devfrom
bensantora wants to merge 4 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
OpenCode no longer relies on ripgrep, so remove the advice to use 'rg' from the grep tool description. This also resolves the contradiction with the bash tool which says to use Grep (NOT rg). Closes anomalyco#22820
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22802
Type of change
What does this PR do?
If users mistakenly put config keys like $schema or provider in auth.json, then Auth.all() would include them as undefined entries, showing 'undefined' in opencode auth list output. This fix filters out entries that fail schema decoding in Auth.all(). Invalid keys should now get stripped, leaving only valid auth entries
How did you verify your code works?
Tested locally by adding $schema and provider keys to auth.json — they were correctly filtered out and didn't appear in opencode auth list output
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.