fix(tui): update toast duration handling to use default value#23395
Merged
rekram1-node merged 8 commits intoanomalyco:devfrom Apr 26, 2026
Merged
fix(tui): update toast duration handling to use default value#23395rekram1-node merged 8 commits intoanomalyco:devfrom
rekram1-node merged 8 commits intoanomalyco:devfrom
Conversation
JohnTNP
reviewed
Apr 19, 2026
Contributor
|
Have not personally tested, but it looks pretty reasonable to me. |
Collaborator
|
/review |
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23394
Closes #23613
Type of change
What does this PR do?
This PR adds back a defualt duration value of
5000, it got broken since the PR change 675a46e#diff-cc994057bfc51f2b10c6a0251f9dbffc10e875626473e48812cc49cd89ef57b9L59, removing the parse that would add the default originally.How did you verify your code works?
Tested on my local machine with the change added in.
Screenshots / recordings
BEFORE
Screen.Recording.2026-04-19.at.09.37.15.mov
AFTER
Screen.Recording.2026-04-19.at.09.44.30.mov
Checklist