fix(mcp): stop OAuth callback server after authentication completes#23572
Open
hchangjae wants to merge 2 commits into
Open
fix(mcp): stop OAuth callback server after authentication completes#23572hchangjae wants to merge 2 commits into
hchangjae wants to merge 2 commits into
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23568
Type of change
What does this PR do?
The OAuth callback server (port 19876) stays running after
authenticate()completes. When multiple TUI instances run, the first instance holds the port — subsequent instances register state in their ownpendingAuthsMap but callbacks arrive at the first instance wherependingStates=[], causing CSRF errors.Adds
stopIfIdle()that stops the server only whenpendingAuthsis empty, called afterauthenticate()resolves. Safe for concurrent auth flows.How did you verify your code works?
authenticate()to confirm cleanup on success and state-mismatch errorstopIfIdle()guards onpendingAuths.size === 0so concurrent flows are unaffectedEffect.tryPromise().pipe(Effect.ignore)Checklist