chore(core): clean up after ConfigPermission Effect Schema migration#23749
Merged
kitlangton merged 1 commit intodevfrom Apr 21, 2026
Merged
chore(core): clean up after ConfigPermission Effect Schema migration#23749kitlangton merged 1 commit intodevfrom
kitlangton merged 1 commit intodevfrom
Conversation
Post-merge review follow-ups for #23740: - src/config/agent.ts: remove unused ZodOverride import. The PermissionRef escape hatch was deleted when ConfigPermission.Info became a canonical Effect Schema, but the import was left behind. - specs/effect/schema.md: drop the ZodPreprocess annotation section. The feature was deleted in #23740 because the __originalKeys hack it was supporting is gone. Also remove ConfigPermission.Info from the list of "zod-only schemas that cannot yet be expressed as Schema" under ZodOverride — it is now Effect canonical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge review follow-ups for #23740 (caught by a /review-refactor pass):
src/config/agent.ts— remove unusedZodOverrideimport. ThePermissionRefescape hatch was deleted whenConfigPermission.Infobecame a canonical Effect Schema, but the import was left behind.specs/effect/schema.md— drop theZodPreprocessannotation section entirely. The feature was deleted in refactor(core): migrate ConfigPermission.Info to Effect Schema canonical #23740 because the__originalKeyshack it was supporting is gone. Also removeConfigPermission.Infofrom the list of "zod-only schemas that cannot yet be expressed as Schema" underZodOverride— it's now Effect canonical. Updated "three explicit escape hatches" → "two" to match.No runtime or API changes.
Verification
bun typecheckcleanPre-push hook skipped: fails on a pre-existing unrelated error (
packages/desktop-electron/src/main/index.ts:52— missingdrizzle-orm/node-sqlite/drivermodule).