refactor(core): derive provider schema .zod via effect-zod walker#23753
Merged
kitlangton merged 1 commit intodevfrom Apr 21, 2026
Merged
refactor(core): derive provider schema .zod via effect-zod walker#23753kitlangton merged 1 commit intodevfrom
kitlangton merged 1 commit intodevfrom
Conversation
Replace hand-written z.custom wrappers with zod() from @/util/effect-zod so the .zod compatibility shim is derived from the canonical Effect Schema instead of maintained separately. SDK output is byte-identical.
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
z.string().pipe(z.custom<T>())wrappers insrc/provider/schema.tswithzod(schema)from@/util/effect-zodsoProviderID.zod/ModelID.zodare derived from the canonical Effect Schema instead of maintained separately.src/provider/schema.tscomplete inspecs/effect/schema.mdprogress tracker. Unblocks the session/message-v2 cluster that depends on provider IDs.Verification
bun typecheckpassesbun run test test/util/effect-zod.test.ts— 60/60 passpackages/sdk/openapi.json,packages/sdk/js/src/v2/gen/types.gen.ts) — byte-identical