refactor(core): migrate MessageV2 message DTOs (User/Assistant/Part/Info/WithParts) to Effect Schema#23757
Merged
kitlangton merged 1 commit intodevfrom Apr 22, 2026
Merged
Conversation
27da9ba to
ec4f641
Compare
bc8ca4b to
eebe1f7
Compare
ec4f641 to
f93bc46
Compare
eebe1f7 to
c7ba857
Compare
…nfo/WithParts) to Effect Schema Continues the session-domain Schema migration. The assistant error union still references NamedError-based Zod errors via ZodOverride; errors migrate in a separate slice.
c7ba857 to
6241e36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fourth piecemeal slice of the session-domain Effect Schema migration, stacked on #23756.
User,Assistant,Partdiscriminated union,Info, andWithPartsto Effect Schema.Partdefinition with a properSchema.Unionthat annotates `discriminator: "type"` + `identifier: "Part"`.Assistant.errorkeeps a Zod-side discriminated union viaZodOverridebecauseNamedError.create(...)errors are still Zod (error migration is intentionally out of scope for this PR).Acceptance check
Follow-up
Remaining Zod in `message-v2.ts`: