fix: handle outputSchema compilation errors in MCP tool discovery#24015
Closed
k-i-k-s wants to merge 1 commit intoanomalyco:devfrom
Closed
fix: handle outputSchema compilation errors in MCP tool discovery#24015k-i-k-s wants to merge 1 commit intoanomalyco:devfrom
k-i-k-s wants to merge 1 commit intoanomalyco:devfrom
Conversation
When an MCP server returns outputSchema in its tools/list response, the SDK's default AjvJsonSchemaValidator can throw during schema compilation, causing listTools() to fail entirely. This makes the server show "Failed to get tools" even though the tools themselves are valid. opencode doesn't use output schemas (only inputSchema is read in convertMcpTool), so validation failures should be non-fatal. Wrap AjvJsonSchemaValidator with a TolerantJsonSchemaValidator that catches compilation errors and returns a permissive fallback. Pass it to both Client constructors via the SDK's jsonSchemaValidator option. Closes anomalyco#21373
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #21592 - "fix: tolerate outputSchema compilation failures in MCP tool discovery" Why it's related: This PR addresses the same issue - handling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21373
Type of change
What does this PR do?
→ Recreated PR from @claygeo following PR template
When an MCP server returns
outputSchemain itstools/listresponse, the SDK's defaultAjvJsonSchemaValidatorcan throw during schema compilation viaajv.compile(). This error propagates throughlistTools()→cacheToolMetadata(), causing opencode'sdefs()function to catch the error and returnundefined, which results in the server being marked as "Failed to get tools".opencode doesn't use output schemas at all — only
inputSchemais read inconvertMcpTool(). So validation failures onoutputSchemashould never prevent tool discovery.Fix: Create a
TolerantJsonSchemaValidatorthat wrapsAjvJsonSchemaValidatorwith try/catch ingetValidator(). On compilation failure, returns a permissive fallback validator. Pass it to bothnew Client()calls via the SDK'sjsonSchemaValidatoroption.How did you verify your code works?
tsc --noEmit)Clientconstructor correctly receives custom validator (verified via SDK source)Screenshots / recordings
N/A
Checklist