fix(provider): honor per-model reasoning token pricing#24233
Closed
willsarg wants to merge 1 commit into
Closed
Conversation
Plumbs an optional reasoning field through the cost schemas (models.dev config, provider schema, user-config override merge) and uses it in Session.getUsage, falling back to the output rate when unset. This addresses the TODO comment next to the old new Decimal(tokens.reasoning).mul(costInfo?.output ?? 0) which was hardcoding reasoning tokens at the output rate. Backward compatible: when no reasoning cost is defined the behavior is unchanged.
This was referenced Apr 25, 2026
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #24231
Type of change
What does this PR do?
Addresses the
TODOinSession.getUsagethat hardcoded reasoning tokens at the output rate. Adds an optionalreasoningprice to the cost schemas (config/provider.ts,provider/models.ts,provider/provider.ts), threads it through the user-override merge, and uses it ingetUsagewith the output rate as fallback.Backward compatible — when
cost.reasoningis absent, behavior is unchanged.How did you verify your code works?
Two tests in
compaction.test.ts: one asserting reasoning tokens are charged atcost.reasoningwhen set, one guarding the fallback path.bun test test/session/compaction.test.tspasses,bun typecheckclean.Checklist