Skip to content

fix(config): preserve permission order with Effect decode#24308

Merged
kitlangton merged 2 commits intodevfrom
kit/effect-config-parser
Apr 25, 2026
Merged

fix(config): preserve permission order with Effect decode#24308
kitlangton merged 2 commits intodevfrom
kit/effect-config-parser

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • Decode loaded Config.Info with Effect Schema using propertyOrder: \"original\" so permission config precedence preserves user key order.
  • Move agent config normalization to Effect Schema and remove the permission-specific Zod override.
  • Replace remaining Config.Info Zod-only schema islands with Effect schemas while keeping .zod compatibility exports.

Tests

  • bun typecheck from packages/opencode
  • bun run test:ci test/config/config.test.ts test/config/agent-color.test.ts test/config/markdown.test.ts test/config/tui.test.ts test/permission/next.test.ts from packages/opencode

Notes

  • Full bun run test:ci was attempted and hit an existing provider test timeout; rerunning test/provider/provider.test.ts alone also timed out on a different provider test.

@kitlangton kitlangton merged commit a9740b9 into dev Apr 25, 2026
9 checks passed
@kitlangton kitlangton deleted the kit/effect-config-parser branch April 25, 2026 17:30
vaur94 pushed a commit to vaur94/opencode that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant