fix(read): match project-relative permissions#24320
Open
pascalandr wants to merge 3 commits intoanomalyco:devfrom
Open
fix(read): match project-relative permissions#24320pascalandr wants to merge 3 commits intoanomalyco:devfrom
pascalandr wants to merge 3 commits intoanomalyco:devfrom
Conversation
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: The search found one related PR that might be worth checking:
The other results (PR #14540, #17943, #18721) are related to permissions and paths but seem to address different specific issues. No duplicate PRs found |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
Apr 26, 2026
…ode shell continuations - anomalyco/opencode#24443 merge-after-nits: preserve reasoning_content on second interleaved transform pass (DeepSeek 400 fix); flag scoped catch-all blast radius - anomalyco/opencode#24320 merge-as-is: project-relative pattern in Read tool ctx.ask so user-config deny rules actually fire - qwen-code#3600 merge-after-nits: backslash-LF continuation handling in splitCommands, with CRLF security-invariant test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23048
Related: #22676 addresses the same path-permission area more broadly inside
Permission.ask()forread,edit, andexternal_directory. This PR is the smaller targeted fix for the reportedreadpath mismatch only. If #22676 is merged first, this PR can likely be closed as covered by the broader change.Type of change
What does this PR do?
The read tool asked for permission with an absolute path even for files inside the project. Project config rules are commonly written as project-relative paths, so exact deny rules did not match. This uses the project-relative path for in-worktree reads and keeps absolute paths for external files.
How did you verify your code works?
bun test test/tool/read.test.tsbun typecheckfrompackages/opencodebun turbo typecheckScreenshots / recordings
N/A, non-UI change.
Checklist