fix(editor): reject lock files with no workspace match for cwd#24323
Merged
jlongster merged 1 commit intoanomalyco:devfrom Apr 26, 2026
Merged
Conversation
Without a minimum score threshold, opencode would connect to any VSCode lock file in ~/.claude/ide/ even when the workspace folders had no relation to the current working directory. This caused cross-directory IDE context injection — e.g. a WezTerm session in an unrelated dir receiving file-open events from a VSCode window. Filter lock files to only those whose workspaceFolders contain cwd before sorting. Replace the binary pathContains check with pathContainsLength so the sort can prefer the most specific (deepest) workspace match, falling back to mtime for ties. Removes scoreEditorLock which is no longer needed.
jlongster
force-pushed
the
fix/editor-cross-directory-lock-injection
branch
from
c146a7e to
bdde58c
Compare
Contributor
|
great catch, thank you! I tested this and looks like it's working well, will merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without a minimum score threshold, opencode would connect to any VSCode lock file in ~/.claude/ide/ even when the workspace folders had no relation to the current working directory. This caused cross-directory IDE context injection
Issue for this PR
Closes #24295
Type of change
What does this PR do?
pathContainsLengthso the sort can prefer the most specific (deepest) workspace match, falling back to mtime for ties.How did you verify your code works?
selection_changedevents are still received for files within the workspaceChecklist