fix: guard workspace mutation against stale session effect#24543
Open
alfredocristofano wants to merge 3 commits into
Open
fix: guard workspace mutation against stale session effect#24543alfredocristofano wants to merge 3 commits into
alfredocristofano wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #24542
Type of change
What does this PR do?
Fixes a race condition in the session route where an async effect could mutate workspace state for the wrong session if the user navigated away while the operation was in-flight.
The effect now captures
currentSessionIDbefore the asyncsdk.client.session.get()call and guards the mutation withif (route.sessionID !== currentSessionID) returnafter the await. All references within the effect and catch handler usecurrentSessionIDfor consistency.How did you verify your code works?
Verified the guard correctly short-circuits when the session has changed during the async operation, preventing workspace state from leaking into the wrong session.
Checklist