session: synthesize reasoning-start when stream omits it#25185
Closed
jackmazac wants to merge 1 commit intoanomalyco:devfrom
Closed
session: synthesize reasoning-start when stream omits it#25185jackmazac wants to merge 1 commit intoanomalyco:devfrom
jackmazac wants to merge 1 commit intoanomalyco:devfrom
Conversation
wrapStream middleware enqueues reasoning-start before delta/end when the provider skipped the opening chunk for that id.
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Author
|
Closing to reopen with a linked issue and the repo PR template per CONTRIBUTING. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some model streams send reasoning updates without ever sending a matching “reasoning started” marker first. Downstream code then sees deltas or ends for an id it never opened, which can break ordering or UI assumptions. This adds a small stream normalizer so every reasoning id gets an explicit start before any delta or end.
Problem (plain language)
Think of reasoning like a paragraph: you expect “paragraph begins,” then sentences, then “paragraph ends.” If the provider skips the “begins” line and only sends middle sentences, anything that tracks open blocks by id gets confused. Users may see glitches or missing reasoning; worse, the stack may mishandle chunks.
Technical breakdown
wrapStreamhook on language-model middleware.reasoning-delta/reasoning-endfor an id before areasoning-startwith that id.transformParams; this change normalizes the stream so each id is self-consistent.Solution
packages/opencode/src/session/llm.ts, extend the existing stream middleware withwrapStream.reasoning-start.reasoning-deltaorreasoning-endwithout a prior start for that id, enqueue a syntheticreasoning-startfirst, then the original chunk.Files
packages/opencode/src/session/llm.tsHow to test
From
packages/opencode:Merge order
This PR does not depend on PR: session stripReasoning / compaction. It can land before or after that change. If both merge, behavior stacks: compaction strips reasoning from history, while this hook fixes live stream ordering for reasoning chunks.