fix(opencode): synthesize reasoning-start for incomplete streams#25195
Closed
jackmazac wants to merge 1 commit into
Closed
fix(opencode): synthesize reasoning-start for incomplete streams#25195jackmazac wants to merge 1 commit into
jackmazac wants to merge 1 commit into
Conversation
wrapStream middleware enqueues reasoning-start before delta/end when the provider skipped the opening chunk for that id.
Author
|
Closing per contributor request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #25191
Type of change
What does this PR do?
When a model stream emits reasoning deltas without a preceding
reasoning-startevent, the LLM wrapper injects a synthetic start so downstream session/UI logic always sees a well-formed reasoning span.How did you verify your code works?
From
packages/opencode:bun typecheckand stream/session tests touchingwrapStream/ LLM pipeline where applicable.Screenshots / recordings
N/A — not a UI change.
Checklist