fix(tui): retain current model and agent across session switches#25285
Closed
saisharan0103 wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(tui): retain current model and agent across session switches#25285saisharan0103 wants to merge 1 commit intoanomalyco:devfrom
saisharan0103 wants to merge 1 commit intoanomalyco:devfrom
Conversation
…malyco#4930) Only initialize the agent/model/variant from a session's last user message on the very first session sync. On subsequent session switches, preserve the user's current selection instead of reverting to the session's historical configuration.
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Related PR FoundPR #24508: "feat: toggle to keep model/agent when switching sessions"
PR #17190: "fix(app): keep selected model across new sessions"
|
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #4930
Type of change
What does this PR do?
When the user switched between sessions via
Ctrl+X l, the prompt'screateEffectwatchingprops.sessionIDreset the agent and model from the picked session's last user message every time, overriding whatever the user had selected before the switch.The fix adds an
initializedflag in that effect so the restoration runs only on the first session sync (initial app load), giving the TUI sensible defaults from the session on startup. On every subsequent session switch the effect short-circuits and leaves the user's currentlocal.agent/local.model/local.model.variantuntouched. The existing primary-agent guard and--agentCLI override still apply.How did you verify your code works?
bun run typecheck(tsgo) — clean.oxlint packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx— same 10 pre-existing warnings before and after the change, 0 errors (verified by stashing the change and re-running).syncedSessionIDundefined,initializedfalse) restores from the session's last user message and setsinitialized = true; subsequentCtrl+X lswitches updatesyncedSessionIDbut skip the restoration block.Screenshots / recordings
N/A
Checklist