Extract InstanceStore.provide helper#25372
Merged
kitlangton merged 1 commit intodevfrom May 2, 2026
Merged
Conversation
Adds InstanceStore.provide(input, effect) — loads the cached instance context and provides InstanceRef to the wrapped effect. Replaces the inline makeInstanceContext + provideService(InstanceRef) dance in the HttpApi middleware, and gives non-middleware callers (CLI bridges, background jobs) a single primitive for entering an instance scope from Effect-native code.
kitlangton
force-pushed
the
kit/instance-store-provide
branch
from
3a18a72 to
b964366
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The instance-context middleware was inlining `store.load` + `Effect.provideService(InstanceRef, ctx)`. Any other Effect-native call site that needs to enter an instance scope would copy that same pattern. Extracting it as `InstanceStore.provide` removes the duplication and makes the next conversion (CLI commands moving to native Effect bodies) a one-liner.
Tests