fix(tui): stop plugin selection mouse jumps#25902
Open
3351163616 wants to merge 1 commit intoanomalyco:devfrom
Open
fix(tui): stop plugin selection mouse jumps#259023351163616 wants to merge 1 commit intoanomalyco:devfrom
3351163616 wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
3351163616
force-pushed
the
fix/plugins-mouse-selection-jump
branch
from
4192785 to
9204724
Compare
3351163616
force-pushed
the
fix/plugins-mouse-selection-jump
branch
from
9204724 to
cf1fef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #25903
Type of change
What does this PR do?
Fixes the plugin manager selection jumping when using the mouse. The plugin manager was feeding
DialogSelectmovement back intocurrent, so hover selection causedDialogSelectto re-center the list while the cursor was still over it.This removes that feedback loop and lets
DialogSelectkeep the transient hover/keyboard selection internally.How did you verify your code works?
/home/a33511/.bun/bin/bun typecheckfrompackages/opencode.devand fix binaries and compared the plugin manager behavior.Screenshots / recordings
Not included. This is a TUI mouse interaction fix and was verified locally with before/after binaries.
Checklist