fix(opencode): recover malformed GLM/NVIDIA tool calls#25971
Open
ctharvey wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): recover malformed GLM/NVIDIA tool calls#25971ctharvey wants to merge 1 commit intoanomalyco:devfrom
ctharvey wants to merge 1 commit intoanomalyco:devfrom
Conversation
3909951 to
80416b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #25970
Type of change
What does this PR do?
This hardens the
@ai-sdk/openai-compatiblepath against malformed tool-call payloads seen fromnvidia/z-ai/glm-5.1.It does three things:
function_callresponses alongsidetool_callsidor receivefunction.namelaterfinish_reason: "tool_calls"but no usable tool name, performs one non-stream recovery request and then raises a clear error instead of hangingThis keeps the provider bug from turning into a stalled OpenCode session.
How did you verify your code works?
bun typecheckfrompackages/opencodebun test test/provider/copilot/openai-compatible-tool-call-id-fallback.test.ts --timeout 30000frompackages/opencodebun run build -- --single --skip-embed-web-uifrompackages/opencodedist/opencode-windows-x64/bin/opencode.exe run --format json --dangerously-skip-permissions -m nvidia/z-ai/glm-5.1 "check your memory"on build0.0.0-dev-202605060426Notes:
bun typecheckcurrently fails in unrelated existingpackages/enterprise/src/custom-elements.d.tspackages/opencodesuite also has existing Windows failures in unrelated PTY/symlink/filesystem tests, but the touched provider test passesScreenshots / recordings
Not a UI change.
Checklist