feat: Preserve todo progress during compaction#25982
Open
pzy2000 wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18071
Closes #18564
Closes #5934
Closes #15096
Type of change
What does this PR do?
Todo progress could be lost from the model context after compaction because the summary relied on the model to remember and include it.
This PR adds deterministic compaction anchors for the current
TodoWritestate, plus the active plan file path when one exists. The anchors are included during compaction and written back into the compacted summary after it succeeds. Repeated compactions strip old anchor blocks first, so stale todo statuses are replaced by the latest state.How did you verify your code works?
Added regression tests for:
Ran:
bun test test/session/compaction.test.tsbun typecheckgit diff --checkScreenshots / recordings
N/A, this is not a UI change.
Checklist