feat: better image handling (auto resize & max size constraints)#26401
Open
rekram1-node wants to merge 17 commits intodevfrom
Open
feat: better image handling (auto resize & max size constraints)#26401rekram1-node wants to merge 17 commits intodevfrom
rekram1-node wants to merge 17 commits intodevfrom
Conversation
Collaborator
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
Author
|
/review |
Collaborator
Author
|
/review |
Collaborator
Author
|
/review |
| const JPEG_QUALITIES = [80, 85, 70, 55, 40] | ||
| const log = Log.create({ service: "image" }) | ||
|
|
||
| type Photon = typeof import("@silvia-odwyer/photon-node") |
Contributor
There was a problem hiding this comment.
Suggestion, human can decide: this type alias appears to be unused. Since the style guide asks us to avoid extra single-use or unnecessary names, consider removing it unless it is intended for a near-term exported API.
| variant: input.variant, | ||
| }, | ||
| { message: info, parts }, | ||
| { message: info, parts: resolvedParts }, |
Contributor
There was a problem hiding this comment.
Suggestion, human can decide: chat.message now receives resolvedParts, but the saved message and Prompted event use the normalized parts built just below. That means plugins can observe or mutate the pre-resize image data, including large base64 payloads that are not what the model ultimately receives. Consider normalizing before this hook, or otherwise make the hook payload match the persisted parts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP