fix(ui): clear permission after response#26905
Open
donicrosby wants to merge 4 commits into
Open
Conversation
Remove the accepted permission from the local sync cache after the server confirms the response so child-session permission prompts do not remain stuck in the composer. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the accepted permission from the local sync cache after the server confirms the response so child-session permission prompts do not remain stuck in the composer.
Ultraworked with Sisyphus
Issue for this PR
Closes #26907
Type of change
What does this PR do?
When a child session permission response succeeds, remove that permission from the local sync cache. The server already accepts the response, but the composer can keep rendering the stale permission prompt until another sync event arrives.
This keeps the UI state aligned with the confirmed server response so the prompt clears immediately after approval.
How did you verify your code works?
bun typecheckfrompackages/appbun run buildfrompackages/appbun test --preload ./happydom.ts ./src/context/global-sync/event-reducer.test.tsbun turbo typecheckNote:
session-composer-state.test.tsfails on cleanHEADwith a Solid router client-only import error before running tests, so that failure is pre-existing.Screenshots / recordings
Before, after clicking "Allow once", the permission prompt could remain stuck in the composer:
Permission prompt stuck before fix
After this change, the confirmed permission response clears the prompt from the composer:
Permission prompt cleared after fix
Checklist
If you do not follow this template your PR will be automatically rejected.