fix: grep external directory permission evaluation#26958
Merged
Conversation
Collaborator
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| : path.join(ins.directory, params.path ?? ".") | ||
| yield* reference.ensure(requested) | ||
| const requestedInfo = yield* fs.stat(requested).pipe(Effect.catch(() => Effect.succeed(undefined))) | ||
| yield* assertExternalDirectoryEffect(ctx, requested, { |
Contributor
There was a problem hiding this comment.
Suggestion only, so please use your judgment: moving the external_directory check before AppFileSystem.resolve means an in-workspace symlink to an external directory is treated as internal by containsPath, so grep can search outside the project without asking. Could we preserve the alias-based permission pattern while still checking the resolved path for the workspace-boundary bypass?
Collaborator
Author
There was a problem hiding this comment.
I would expect this to not get flagged since file is in cwd
leohenon
pushed a commit
to leohenon/opencode-vim
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes grep external-directory permission checks when the requested path resolves through an alias or symlink, such as macOS /var -> /private/var.
Previously, grep canonicalized the requested path with AppFileSystem.resolve() before evaluating external_directory permissions. That meant allow rules written against the user-facing path could miss after realpath normalization, causing an approval prompt even when
the path should have been auto-approved.
This change evaluates external_directory permissions against the originally requested absolute path, while still using the resolved path for the actual ripgrep execution and result handling.
Validation: