effect: move tool flags into RuntimeFlags#27198
Merged
Merged
Conversation
51355ef to
9ef5459
Compare
9ef5459 to
a3c2b87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeFlagsusingConfigServicedefinitions.ToolRegistrytool visibility decisions from directFlagreads toRuntimeFlags.WebSearchToolprovider selection to use the sameRuntimeFlagsvalues as registry visibility.RuntimeFlags.layer(...)variants instead of mutatingFlag.OPENCODE_EXPERIMENTAL_SCOUT.RuntimeFlags.layer()in openToolRegistry.layertest compositions.Notes
OPENCODE_EXPERIMENTAL_WORKSPACESfirst, but it is too coupled to legacy mutableFlagand closed default layers for a small safe PR. This tool-registry cluster is a smaller step that proves the pattern.Verification
bun run test -- test/effect/runtime-flags.test.ts test/tool/registry.test.ts test/tool/websearch.test.ts test/session/snapshot-tool-race.test.tsbunx prettier --check packages/opencode/src/effect/runtime-flags.ts packages/opencode/src/tool/registry.ts packages/opencode/src/tool/websearch.ts packages/opencode/test/effect/runtime-flags.test.ts packages/opencode/test/tool/registry.test.ts packages/opencode/test/session/snapshot-tool-race.test.ts packages/opencode/test/session/prompt.test.tsgit diff --checkSimplify review
Flagcompatibility bridge.bool(...)helper for all false-default boolean flags.Typecheck
bun typecheckcurrently fails on unrelated provider/tool metadata type issues already present in this worktree dependency state; focused tests pass.