Skip to content

refactor(instance): remove remaining bind call sites#27731

Merged
nexxeln merged 4 commits into
devfrom
nxl/bridge-file-watcher-callback
May 15, 2026
Merged

refactor(instance): remove remaining bind call sites#27731
nexxeln merged 4 commits into
devfrom
nxl/bridge-file-watcher-callback

Conversation

@nexxeln
Copy link
Copy Markdown
Member

@nexxeln nexxeln commented May 15, 2026

summary

  • centralize instance/workspace callback restoration in EffectBridge.bind
  • migrate file watcher, workflow approval, and database callbacks off InstanceState.bind
  • keep callback owners simple while preserving sync watcher/DB behavior and async approval flow

testing

  • bun typecheck
  • bun test "test/session/llm.test.ts"
  • bun test "test/storage/db.test.ts" "test/sync/index.test.ts"
  • bun test "test/file/watcher.test.ts" (5 watcher cases pass; the symlinked .git case times out locally, and the same timeout reproduces with the original callback restored on dev)

@nexxeln nexxeln changed the title refactor(watcher): bridge native event callback refactor(instance): remove instance bind call sites May 15, 2026
@nexxeln nexxeln changed the title refactor(instance): remove instance bind call sites refactor(instance): remove remaining bind call sites May 15, 2026
@nexxeln nexxeln merged commit fa9a2cb into dev May 15, 2026
10 checks passed
@nexxeln nexxeln deleted the nxl/bridge-file-watcher-callback branch May 15, 2026 14:34
rustybret pushed a commit to rustybret/opencode that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant