feat(task-tool): emit diagnostic when subagent returns no text part#27888
Closed
PeterPonyu wants to merge 1 commit into
Closed
feat(task-tool): emit diagnostic when subagent returns no text part#27888PeterPonyu wants to merge 1 commit into
PeterPonyu wants to merge 1 commit into
Conversation
…nomalyco#24447) When a subagent session completes without producing any text part, the parent now receives a structured diagnostic block instead of a silent empty <task_result>. The block includes the finish reason, any error details, and the list of part types actually produced, making it straightforward to distinguish an intentional empty reply (text part present but empty) from a missing-text-part scenario. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskTool.runTaskpreviously collapsed a missing-text-part scenario into a silent empty string viaresult.parts.findLast(…)?.text ?? "", giving the parent no indication of why the result was empty.text === "") is preserved as-is, keeping the existing behaviour for that case.Test plan
Three new cases added to
packages/opencode/test/tool/task.test.ts:outputcontains that text (happy path unchanged)outputwraps""in<task_result></task_result>, no diagnostic block emittedoutputcontains"Subagent completed without a text response.","finish:","error:", and"parts:"linesRelated
🤖 Generated with Claude Code