fix(ui): fallback to execCommand for clipboard copy when navigator.clipboard fails#27993
Merged
Merged
Conversation
…ipboard fails
On the web interface, navigator.clipboard.writeText() can silently fail in
non-HTTPS contexts (localhost) or when the Clipboard API is blocked. Added a
writeClipboard() helper that falls back to document.execCommand('copy') via a
temporary textarea, which works in all browser contexts. Also gate the 'copied'
state update on the actual copy result.
Fixes anomalyco#27992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27992
Type of change
What does this PR do?
navigator.clipboard.writeText()can silently fail in:This PR adds a
writeClipboard()helper that:document.execCommand("copy")using a temporary textarea (works in all browser contexts)navigator.clipboard.writeText()if the execCommand approach failsThis fixes the copy button appearing to do nothing on the web UI.
How did you verify your code works?
Tested manually on the web interface by verifying copy works. The execCommand fallback is a well-known pattern for clipboard operations in web applications.
Checklist