fix: ignore null agent colors#28004
Open
mturac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27988
Type of change
What does this PR do?
Agent markdown files can accidentally parse
color: #9B59B6ascolor: null, because YAML treats the#...part as a comment when the value is not quoted. That invalid color currently prevents the agent config from loading cleanly, which can make larger agent directories appear partially missing.This PR treats a null agent color as unset during config normalization, so the agent still loads and keeps its prompt, mode, description, and other fields.
How did you verify your code works?
bun test test/config/config.test.ts -t "loads many agents"bun typecheckbun run lint packages/opencode/src/config/agent.ts packages/opencode/test/config/config.test.ts(0 errors; existing warnings inconfig.test.ts)git diff --check origin/dev...HEADbun turbo typecheckScreenshots / recordings
Not applicable; config loading regression test covers the behavior.
Checklist