fix(opencode): dedupe concurrent Codex OAuth refreshes#28236
Merged
rekram1-node merged 2 commits intoMay 21, 2026
Conversation
Collaborator
|
we try to avoid mocks or global overrides, so making a small change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28234
Type of change
What does this PR do?
Codex OAuth refreshes are now shared while one refresh is already in flight. Without that guard, two requests that arrive after the access token has expired can both try to refresh the same rotating refresh token, which can leave the later request failing after the token has already changed.
This keeps the change local to the Codex auth loader and persists refreshed credentials once per shared refresh.
How did you verify your code works?
bun test test/plugin/codex.test.tsbun typecheckI also added a regression test that starts two Codex requests against expired auth state and verifies only one refresh request and one auth update occur.
Screenshots / recordings
N/A - no UI changes.
Checklist